Conversation
| return; | ||
| } | ||
|
|
||
| if (!uri.IsAbsoluteUri || !(uri.Scheme.StartsWith("http", StringComparison.OrdinalIgnoreCase) |
There was a problem hiding this comment.
uri.Scheme.StartsWith("http", StringComparison.OrdinalIgnoreCase) || uri.Scheme.StartsWith("https", StringComparison.OrdinalIgnoreCase) === uri.Scheme.StartsWith("http", StringComparison.OrdinalIgnoreCase)
There was a problem hiding this comment.
I think Catel even has StartsWithIgnoreCase and StartsWithAnyIgnoreCase
| || uri.Scheme.StartsWith("https", StringComparison.OrdinalIgnoreCase))) | ||
| { | ||
| string modifiedUriString; | ||
| if (uri.IsAbsoluteUri) |
There was a problem hiding this comment.
maybe there is a way not to check it twice
GeertvanHorrik
left a comment
GeertvanHorrik
left a comment
There was a problem hiding this comment.
Unit tests are missing.
But, for example, what if I want to launch an app like this:
myapp://myaction
Will that no longer be possible?
| return; | ||
| } | ||
|
|
||
| if (!uri.IsAbsoluteUri || !(uri.Scheme.StartsWith("http", StringComparison.OrdinalIgnoreCase) |
There was a problem hiding this comment.
I think Catel even has StartsWithIgnoreCase and StartsWithAnyIgnoreCase
GeertvanHorrik
left a comment
GeertvanHorrik
left a comment
There was a problem hiding this comment.
How can we be sure the behavior is correct if unit tests are missing?
3 participants
Description of Change
Issues Resolved
API Changes
None
Platforms Affected
Behavioral Changes
None
Testing Procedure
PR Checklist