feat: add group colors and harden Grok Build tool calling - #20
Draft
WilliamWang1721 wants to merge 3 commits into
Draft
feat: add group colors and harden Grok Build tool calling#20WilliamWang1721 wants to merge 3 commits into
WilliamWang1721 wants to merge 3 commits into
Conversation
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign, please reply with the following comment:
You only need to sign once — it will be valid for all your future contributions to this project. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft tracks the reviewed implementation for two related improvements:
Group presentation and usability
#RRGGBBvalidation.+N.161_add_group_color.sql.Grok Build Tool Calling compatibility
tool_choiceinto Responses format.response.function_call_arguments.done,response.output_item.done, and terminal response snapshots.tool_choicewhen the selected unsupported custom tool (notablyapply_patch) is filtered.function_call, rather than treating an HTTP 200 text response as success.Code review fixes included in the reviewed payload
color; the earlier misalignment could panic during application startup by assigning a string default torate_multiplier.Reviewed source payload
The complete reviewed Stage 12 source archive is retained here:
LightBridge-0.2.80-group-color-grok-toolcall-stage12-full.zipThe repository
mainbranch is currently at v0.2.91. The archive was compared against the current architecture before this draft was opened, and the PR is intentionally kept Draft until the payload is applied without overwriting newer Router/protocol work frommain.Sandbox validation completed
gofmtand AST parsing across the repository.Required before Ready for Review
main.@ai-sdk/openai-compatible).