Skip to content

allow providing a custom certificate store #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdegomme wants to merge 2 commits into
base: main
Choose a base branch
from
Open

allow providing a custom certificate store #297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccb6ab0
allow providing a custom certificate store
bdegomme Apr 24, 2025
decafa2
add comment
bdegomme Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/ews/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class Viewpoint::EWS::Connection
# seconds
# @option opts [Fixnum] :connect_timeout override the default connect timeout
# seconds
# @option opts [OpenSSL::X509::Store] :cert_store a custom cert store
# @option opts [Array] :trust_ca an array of hashed dir paths or a file
# @option opts [String] :user_agent the http user agent to use in all requests
def initialize(endpoint, opts = {})
Expand All @@ -40,7 +41,13 @@ def initialize(endpoint, opts = {})
@httpcli = HTTPClient.new
end

if opts[:trust_ca]
if opts[:cert_store].is_a?(OpenSSL::X509::Store)
@log.debug 'Applying custom cert_store provided via opts[:cert_store]'
# Assign the provided store directly
@httpcli.ssl_config.cert_store = opts[:cert_store]

@log.debug 'Skipping original :trust_ca handling due to provided :cert_store.'
elsif opts[:trust_ca]
@httpcli.ssl_config.clear_cert_store
opts[:trust_ca].each do |ca|
@httpcli.ssl_config.add_trust_ca ca
Expand Down