Skip to content

Conversation

@aragan
Copy link
Contributor

@aragan aragan commented Dec 14, 2025

Updated version and author information, added HUD functionality for displaying roll information, and improved command handling.

image

Updated version and author information, added HUD functionality for displaying roll information, and improved command handling.
@z16
Copy link
Member

z16 commented Dec 14, 2025

We cannot accept the PR in this state. You need to make sure that existing functionality is not changed, to avoid disruption to users. You should re-add all the deleted chat output code, and work your new code into that. The HUD should be toggleable, and ideally default to off.

Further, you need to remove the _addon.update field, as that table only has specific fields you should assign to, and this is not one of them.

You should also stick to the established code style within that file. Remove the rt_ prefix from names, and use camelCase, as the rest of the file does. Preserve the command handler structure and the help text. Remove excessive comments and condense multiple blank lines in a row to a single blank line. This goes for all submissions to our repo.

Updated version number and refactored HUD functions for better management and visibility.
@Nifim
Copy link
Contributor

Nifim commented Dec 15, 2025

I assume you are still working on this, but in case you are waiting for more feedback.

You still need to fix the command handler to put it back to the way it was, you are adding functionality try to minimize the changes so that all you are doing is adding code and avoid changing what was already there.

You also need to put all the settings you remove back, the end user is using these settings to control the existing functionality for printing to the chat log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants