Update to 2.3.5 and fix settings#1
Open
AuroraWright wants to merge 1 commit intoWingCH:safari-web-extensionfrom
Open
Update to 2.3.5 and fix settings#1AuroraWright wants to merge 1 commit intoWingCH:safari-web-extensionfrom
AuroraWright wants to merge 1 commit intoWingCH:safari-web-extensionfrom
Conversation
AuroraWright
force-pushed
the
safari-web-extension
branch
from
d6f9b33 to
6aacb39
Compare
AuroraWright
force-pushed
the
safari-web-extension
branch
from
6aacb39 to
4ba84db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems all is needed is to change "chrome.runtime" to "browser.runtime". I tested and everything works fine including saving/loading the settings.