-
Notifications
You must be signed in to change notification settings - Fork 13
fix: 링크 키워드 추출 문제 해결 #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ dependencies = [ | |
| "langchain-openai>=1.1.6", | ||
| "langgraph>=1.0.0", | ||
| "markdown>=3.10", | ||
| "playwright>=1.58.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Search for Playwright install steps, browser path config, and environment variables
echo "=== Searching for playwright install patterns ==="
rg -n "playwright install|PLAYWRIGHT_BROWSERS_PATH|PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD" --max-count=20
echo ""
echo "=== Searching in Docker/CI files ==="
rg -n "playwright" -g "Dockerfile*" -g "*.yml" -g "*.yaml" --max-count=20
echo ""
echo "=== Searching in documentation ==="
rg -n "playwright" -g "*.md" --max-count=20
echo ""
echo "=== Checking for requirements or setup files ==="
find . -name "requirements*.txt" -o -name "setup.py" -o -name "poetry.lock" -o -name "setup.cfg" 2>/dev/null | head -10Repository: WithModulabs/blog-agent Length of output: 369 🏁 Script executed: #!/bin/bash
# Check requirements.txt for Playwright
echo "=== requirements.txt content ==="
cat requirements.txt
echo ""
echo "=== Check for CI/workflow files ==="
find . -type f -path "*/.github/workflows/*" -o -name "*.github.yml" -o -path "*/ci/*" 2>/dev/null | head -20
echo ""
echo "=== List CI/Docker files ==="
ls -la | grep -i docker
ls -la .github/workflows/ 2>/dev/null || echo "No .github/workflows directory"
echo ""
echo "=== Check for docker-compose or Dockerfile ==="
find . -name "Dockerfile*" -o -name "docker-compose*" 2>/dev/null
echo ""
echo "=== Context from CLAUDE.md ==="
sed -n '90,140p' casts/blog_writer/CLAUDE.mdRepository: WithModulabs/blog-agent Length of output: 1981 🏁 Script executed: #!/bin/bash
echo "=== CI Workflow: pr_lint.yml ==="
cat .github/workflows/pr_lint.yml
echo ""
echo "=== CI Workflow: ruff.yml ==="
cat .github/workflows/ruff.yml
echo ""
echo "=== CI Workflow: uv_lock_upgrade.yml ==="
head -50 .github/workflows/uv_lock_upgrade.yml
echo ""
echo "=== Check pyproject.toml for test/scripts config ==="
cat pyproject.toml
echo ""
echo "=== Check for README ==="
ls -la README* 2>/dev/null && head -50 README.mdRepository: WithModulabs/blog-agent Length of output: 5545 Clarify Playwright browser setup requirements based on usage. Playwright is an optional scraper backend (default is BEAUTIFULSOUP), so browser installation is only needed if 🤖 Prompt for AI Agents |
||
| "pydantic-settings>=2.1.0", | ||
| "python-dotenv>=1.0.1", | ||
| "uvicorn[standard]>=0.34.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: WithModulabs/blog-agent
Length of output: 905
🏁 Script executed:
Repository: WithModulabs/blog-agent
Length of output: 1771
🏁 Script executed:
Repository: WithModulabs/blog-agent
Length of output: 492
Distinguish parse failure from empty keyword lists.
The current code uses
if datawhich treats empty lists[]as falsy and unintentionally triggers the regex fallback. Replace the truthiness check with explicit type checking anddata is not Noneto distinguish between parse failure (None) and valid empty results, preventing noise from unnecessary fallback extraction.Suggested fix
🤖 Prompt for AI Agents