add "players in fight" api endpoint to fix classic issue #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emallson
added a commit
to emallson/WoWAnalyzer
that referenced
this pull request
Jan 7, 2026
this replaces the use of combatantinfo with the use of the playerDetails v2 api (see backend PR WoWAnalyzer/server#73). this is a relatively big patch because of the way that so many pieces relied on the initial `combatantinfo` data directly, but most of those places only used the id, name, or guid---all of which are set on `playerDetails` as well
emallson
force-pushed
the
players-in-fight
branch
from
c17a3ea to
9c1a872
Compare
Krealle
approved these changes
Jan 8, 2026
Contributor
Krealle
left a comment
Krealle
left a comment
There was a problem hiding this comment.
Tested with both backend/frontend checked out and looks to be working great!
github-merge-queue bot
pushed a commit
to WoWAnalyzer/WoWAnalyzer
that referenced
this pull request
Jan 8, 2026
* #7565 refactor loading of players within a fight this replaces the use of combatantinfo with the use of the playerDetails v2 api (see backend PR WoWAnalyzer/server#73). this is a relatively big patch because of the way that so many pieces relied on the initial `combatantinfo` data directly, but most of those places only used the id, name, or guid---all of which are set on `playerDetails` as well * remove ranged role icon * fix tests * lint fixes + remove healing cds from raid buff list * ilvl can be undefined * allow name-only urls again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of WoWAnalyzer/WoWAnalyzer#7565
this uses
playerDetailsto get specs for all players in a way that works properly on classic