Skip to content

Revert "Components: Complete WPDS token migration for remaining borders"#79243

Merged
ciampo merged 1 commit into
trunkfrom
revert-79003-upd/79001-components-wpds-border-colors
Jun 16, 2026
Merged

Revert "Components: Complete WPDS token migration for remaining borders"#79243
ciampo merged 1 commit into
trunkfrom
revert-79003-upd/79001-components-wpds-border-colors

Conversation

@ciampo

@ciampo ciampo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Reverts #79003

@ciampo ciampo self-assigned this Jun 16, 2026
@ciampo ciampo requested review from a team and ajitbohra as code owners June 16, 2026 14:47
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
Co-authored-by: aduth <aduth@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the [Package] Components /packages/components label Jun 16, 2026
@ciampo ciampo requested a review from manzoorwanijk June 16, 2026 14:49
@ciampo ciampo added the [Type] Bug An existing feature does not function as intended label Jun 16, 2026
@manzoorwanijk

Copy link
Copy Markdown
Member

Let us see if Storybook smoke test is a success.

@aduth

aduth commented Jun 16, 2026

Copy link
Copy Markdown
Member

@aduth

aduth commented Jun 16, 2026

Copy link
Copy Markdown
Member

From the Slack conversation, I came to the same conclusion, that it's the TODO comments mentioning -wpds- specifically that trigger a different build mechanism and cause the issue. Obviously something fragile there with the build that we'll want to improve but revert in the meantime makes sense.

@ciampo

ciampo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Got to the same conclusion here — I'm working on a small PR with the exact fix, instead of reverting.

@github-actions

Copy link
Copy Markdown

Size Change: -2.12 kB (-0.02%)

Total Size: 8.58 MB

📦 View Changed
Filename Size Change
build/scripts/components/index.min.js 264 kB -1.9 kB (-0.72%)
build/styles/components/style-rtl.css 18 kB -49 B (-0.27%)
build/styles/components/style-rtl.min.css 14.9 kB -61 B (-0.41%)
build/styles/components/style.css 18.1 kB -52 B (-0.29%)
build/styles/components/style.min.css 14.9 kB -55 B (-0.37%)

compressed-size-action

@ciampo

ciampo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Storybook CI check is passing, we can merge as soon as all CI checks pass.

@ciampo ciampo merged commit b68a42b into trunk Jun 16, 2026
49 of 52 checks passed
@ciampo ciampo deleted the revert-79003-upd/79001-components-wpds-border-colors branch June 16, 2026 15:22
@github-actions github-actions Bot added this to the Gutenberg 23.5 milestone Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants