Try adding alignment controls to grid layout#79472
Draft
tellthemachines wants to merge 1 commit into
Draft
Conversation
|
Size Change: +1.6 kB (+0.02%) Total Size: 7.51 MB 📦 View Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Addresses the first part of #62895 (grid parent controls only)
This got complicated because the grid item resize handles follow the item size, which changes if the grid's alignments are other than their default "stretch" value. In order to ensure they work well, we had to do a bunch of changes to the resizer logic.
I've only half reviewed it and have run into a bug while testing where all the grid children become unselectable.
I might not have time to work on this for 7.1, so I'm just leaving this here for now to pick up later.
Testing Instructions
Add a Grid block with children to the page and try changing its justification/alignment. Test with children that have multi-column or multi-row spans.
Use of AI Tools
Written with codex/gpt 5.5.