Skip to content

QueryControls: Complete __next40pxDefaultSize cleanup#79485

Merged
mirka merged 6 commits into
trunkfrom
hard-deprecate-querycontrols-40px
Jun 25, 2026
Merged

QueryControls: Complete __next40pxDefaultSize cleanup#79485
mirka merged 6 commits into
trunkfrom
hard-deprecate-querycontrols-40px

Conversation

@mirka

@mirka mirka commented Jun 24, 2026

Copy link
Copy Markdown
Member

What?

Follow up to #65751 and #64457

QueryControls already unconditionally renders 40px child controls. This PR finishes the remaining bookkeeping: docs, internal prop threading, and ESLint.

Why?

The public __next40pxDefaultSize prop was deprecated in WP 6.7 and has been a noop since #64457 defaulted the component to 40px internally. This aligns docs and lint rules with that reality.

How?

  • Remove __next40pxDefaultSize from the README.
  • Stop threading the prop through internal AuthorSelect and CategorySelect; hardcode it on embedded TreeSelect instances instead.
  • Remove the prop from internal AuthorSelectProps and CategorySelectProps types.
  • Add a restricted-syntax rule to forbid passing __next40pxDefaultSize to QueryControls.

No runtime behavior change.

Testing Instructions

  1. Open Storybook to Components / QueryControls and smoke test the default and single-category stories.
  2. Insert a Latest Posts block and confirm the query controls in the sidebar still render at 40px height.
  3. Confirm no console warnings are logged.

@github-actions github-actions Bot added the [Package] Components /packages/components label Jun 24, 2026
@mirka mirka self-assigned this Jun 24, 2026
@mirka mirka added the [Type] Breaking Change For PRs that introduce a change that will break existing functionality label Jun 24, 2026
@mirka mirka changed the title QueryControls: Hard deprecate 40px default size QueryControls: Complete __next40pxDefaultSize cleanup Jun 24, 2026
@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components and removed [Type] Breaking Change For PRs that introduce a change that will break existing functionality [Package] Components /packages/components labels Jun 24, 2026
@mirka mirka marked this pull request as ready for review June 24, 2026 12:44
@mirka mirka requested review from a team, ajitbohra and manzoorwanijk as code owners June 24, 2026 12:44
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka marked this pull request as draft June 24, 2026 12:52
@mirka mirka marked this pull request as ready for review June 24, 2026 12:53
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Size Change: -8 B (0%)

Total Size: 7.51 MB

📦 View Changed
Filename Size Change
build/scripts/components/index.min.js 264 kB -8 B (0%)

compressed-size-action

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Flaky tests detected in 3a46667.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/28157001491
📝 Reported issues:

@ciampo ciampo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🚀

# Conflicts:
#	tools/eslint/config.mjs
@mirka mirka enabled auto-merge (squash) June 25, 2026 08:28
@mirka mirka merged commit de98c5d into trunk Jun 25, 2026
44 of 45 checks passed
@mirka mirka deleted the hard-deprecate-querycontrols-40px branch June 25, 2026 08:57
@github-actions github-actions Bot added this to the Gutenberg 23.6 milestone Jun 25, 2026
SainathPoojary pushed a commit to SainathPoojary/gutenberg that referenced this pull request Jun 29, 2026
* QueryControls: Hard deprecate 40px default size

* Add changelog

* Remove changelog entry

* Restore WP 6.7 deprecation version on QueryControls

* Fix up

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants