Skip stylesheets with empty href attributes in Site Health audit #2281

theaminuli · 2025-11-27T02:09:43Z

What:

Skip stylesheet link elements that have empty href attributes during the Enqueued Assets Health Check audit.

Why:

Some themes and plugins (like Mesmerize Companion) intentionally use empty href attributes with data-href attributes as a performance optimization technique to defer CSS loading. These stylesheets are non-render-blocking by design, but were being incorrectly flagged as errors ("A valid URL was not provided") in the Site Health Status, negatively impacting site scores.

How:

Added a check for empty string href values in perflab_aea_audit_blocking_assets(). The condition now reads:

if ( ! is_string( $href ) ) {
	continue;
}
$href = trim( $href );
if ( '' === $href ) {
	continue;
}

This skips stylesheets with href="" from being audited, similar to how async CSS with non-standard media attributes is already excluded.

Files changed:

helper.php

Fixes #2278

Updated the check for the href attribute in perflab_aea_audit_blocking_assets to skip processing when href is an empty string, preventing potential issues with invalid asset URLs.

github-actions · 2025-11-27T02:09:52Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: theaminuli <theaminuldev@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

codecov · 2025-11-27T02:18:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.87%. Comparing base (4988642) to head (dccaa9a).
⚠️ Report is 21 commits behind head on trunk.

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk    #2281      +/-   ##
==========================================
+ Coverage   68.85%   68.87%   +0.02%     
==========================================
  Files          90       90              
  Lines        7612     7618       +6     
==========================================
+ Hits         5241     5247       +6     
  Misses       2371     2371

Flag	Coverage Δ
multisite	`68.87% <100.00%> (+0.02%)`	⬆️
single	`35.41% <0.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

plugins/performance-lab/includes/site-health/audit-enqueued-assets/helper.php

westonruter · 2025-11-27T05:43:24Z

Thank you for the PR. Let's also update the unit test to add an assertion for this change.

Co-authored-by: Weston Ruter <westonruter@gmail.com>

Introduces a test case to verify that styles enqueued with an empty href are handled correctly. This addresses issue WordPress#2278 and ensures that such styles are not included in the audited assets.

theaminuli · 2025-11-27T16:20:53Z

Test Added

I've added test coverage for the empty href attribute fix in the test_perflab_aea_audit_enqueued_styles() test method.

What the test does:

Enqueues a stylesheet with style-empty-href handle
Verifies that this stylesheet is properly skipped from the audit and doesn't appear in the results

Test assertion:

$empty_href_style = array_filter(
	$assets['styles'],
	static function ( $item ) {
		return 'https://empty-href-style.com' === $item['src'];
	}
);
$this->assertEmpty( $empty_href_style );

This ensures that themes/plugins using performance optimization techniques with href="" won't trigger false positives in Site Health checks.

Thanks to @westonruter for the valuable feedback on implementing this test case!

Files changed:

test-audit-enqueued-assets.php

Corrects whitespace in the test for enqueued assets and adds a docblock line for clarity. No functional changes to the test logic.

westonruter · 2026-01-06T16:50:33Z

...formance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php

+					$tag = str_replace(
+						'href=\'https://empty-href-style.com\'',
+						"href=''",
+						$tag
+					);


Let's use the HTML Tag Processor for this as it is more robust than doing a replacement.

Done in 65b2746

… stylesheets-with-empty-href-attributes

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-06T19:45:14Z

...formance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php

+			function ( $tag, $handle ) {
 				if ( 'style-no-href' === $handle ) {
-					$tag = str_replace( 'href=\'https://no-href-style.com\'', ' ', $tag );
+					$processor = new WP_HTML_Tag_Processor( $tag );
+					$this->assertTrue( $processor->next_tag( 'LINK' ), 'Expected a LINK to be present.' );
+					$this->assertSame( 'stylesheet', $processor->get_attribute( 'rel' ), 'Expected LINK to be a stylesheet.' );
+					$processor->remove_attribute( 'href' );
+					$tag = $processor->get_updated_html();
+				} elseif ( 'style-empty-href' === $handle ) {
+					$processor = new WP_HTML_Tag_Processor( $tag );
+					$this->assertTrue( $processor->next_tag( 'LINK' ), 'Expected a LINK to be present.' );
+					$this->assertSame( 'stylesheet', $processor->get_attribute( 'rel' ), 'Expected LINK to be a stylesheet.' );
+					$processor->set_attribute( 'href', '' );
+					$tag = $processor->get_updated_html();
 				}
 				return $tag;
 			},


The change from static function to function is necessary here because the callback now uses $this to access test assertion methods (lines 184-185, 190-191). However, this pattern is inconsistent with other filter callbacks in this test file, which all use static function (e.g., lines 62, 232, 240, 248, 256, 264).

While the test assertions inside the filter callback can help catch issues earlier, they create coupling between the filter and test context and break the established pattern. Consider either:

Removing the assertions from inside the filter callback (they're not strictly necessary since the test verifies the end result), or

If assertions are needed for debugging, extract the HTML manipulation logic into a helper method that can be called with $this context while keeping the assertions, making the pattern more explicit.

No, thanks.

...formance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php

plugins/performance-lab/includes/site-health/audit-enqueued-assets/helper.php

...formance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/php-test-plugins.yml

plugins/performance-lab/includes/site-health/audit-enqueued-assets/helper.php

...formance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php

… stylesheets-with-empty-href-attributes

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...formance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

plugins/performance-lab/includes/site-health/audit-enqueued-assets/helper.php

...formance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php

Handle empty href in blocking assets audit

0c23fc3

Updated the check for the href attribute in perflab_aea_audit_blocking_assets to skip processing when href is an empty string, preventing potential issues with invalid asset URLs.

theaminuli requested a review from manuelRod as a code owner November 27, 2025 02:09

westonruter added this to the performance-lab n.e.x.t milestone Nov 27, 2025

westonruter added [Type] Bug An existing feature is broken [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Nov 27, 2025

westonruter reviewed Nov 27, 2025

View reviewed changes

plugins/performance-lab/includes/site-health/audit-enqueued-assets/helper.php Outdated Show resolved Hide resolved

theaminuli and others added 2 commits November 27, 2025 21:52

Fix: skip empty stylesheet href values in asset audit

e41bf61

Co-authored-by: Weston Ruter <westonruter@gmail.com>

Add test for enqueued style with empty href

69985a3

Introduces a test case to verify that styles enqueued with an empty href are handled correctly. This addresses issue WordPress#2278 and ensures that such styles are not included in the audited assets.

theaminuli requested review from felixarntz and mukeshpanchal27 as code owners November 27, 2025 16:14

Fix whitespace in test-audit-enqueued-assets.php

756a8aa

Corrects whitespace in the test for enqueued assets and adds a docblock line for clarity. No functional changes to the test logic.

westonruter reviewed Jan 6, 2026

View reviewed changes

westonruter added 2 commits January 6, 2026 08:51

Merge branch 'trunk' of https://github.com/WordPress/performance into…

b74e9b5

… stylesheets-with-empty-href-attributes

Use HTML Tag Processor instead of string replacement

65b2746

Copilot AI review requested due to automatic review settings January 6, 2026 16:57

Copilot AI reviewed Jan 6, 2026

View reviewed changes

swissspidy requested a review from Copilot January 6, 2026 19:41

Copilot started reviewing on behalf of swissspidy January 6, 2026 19:42 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

westonruter added 6 commits January 6, 2026 15:26

Improve comment for special case styles

da861a6

Use example.com for URLs

1a9c1d5

Account for nocache-bfcache being installed

95bc1a7

Incorporate PHP 8.2 fix for unit tests from WordPress#2325

5039c8c

Simplify assertions for the expected scripts and styles

5ceeece

Preserve stripped whitespace

8d07e0e

westonruter requested a review from thelovekesh as a code owner January 6, 2026 23:52

westonruter requested a review from Copilot January 6, 2026 23:53

Copilot started reviewing on behalf of westonruter January 6, 2026 23:53 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

westonruter added 5 commits January 6, 2026 16:00

Remove home URL from test fixtures

dcdc382

Add test case for whitespace in href

f59d415

Merge branch 'trunk' of https://github.com/WordPress/performance into…

ed43c60

… stylesheets-with-empty-href-attributes

Account for whitespace or empty script srcs

065b557

Account for boolean src/href

37668ce

westonruter requested a review from Copilot January 7, 2026 00:36

Copilot started reviewing on behalf of westonruter January 7, 2026 00:36 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

...formance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php Outdated Show resolved Hide resolved

...formance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php Outdated Show resolved Hide resolved

westonruter and others added 3 commits January 6, 2026 16:40

Update comment

507041e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix typo

5655f62

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Declare HTML5 scripts theme support to get a boolean attribute

dccaa9a

Copilot AI reviewed Jan 7, 2026

View reviewed changes

westonruter approved these changes Jan 7, 2026

View reviewed changes

westonruter requested a review from Copilot January 7, 2026 00:54

Copilot started reviewing on behalf of westonruter January 7, 2026 00:55 View session

westonruter merged commit 1f31042 into WordPress:trunk Jan 7, 2026
24 checks passed

Copilot AI reviewed Jan 7, 2026

View reviewed changes

westonruter mentioned this pull request Jan 7, 2026

Follow-up: Skip stylesheets with empty href attributes in Site Health audit #2328

Merged

Skip stylesheets with empty href attributes in Site Health audit #2281

Skip stylesheets with empty href attributes in Site Health audit #2281

Conversation

theaminuli commented Nov 27, 2025 • edited by westonruter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What:

Why:

How:

Files changed:

Fixes #2278

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

codecov bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

westonruter commented Nov 27, 2025

Uh oh!

theaminuli commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Added

What the test does:

Test assertion:

Files changed:

Uh oh!

westonruter Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

theaminuli commented Nov 27, 2025 •

edited by westonruter

Loading

codecov bot commented Nov 27, 2025 •

edited

Loading

theaminuli commented Nov 27, 2025 •

edited

Loading