Add a front end JQuery enqueue check#423
Open
adamsilverstein wants to merge 2 commits intoWordPress:masterfrom
Open
Add a front end JQuery enqueue check#423adamsilverstein wants to merge 2 commits intoWordPress:masterfrom
adamsilverstein wants to merge 2 commits intoWordPress:masterfrom
Conversation
adamsilverstein
commented
May 6, 2022
adamsilverstein
commented
May 6, 2022
| * | ||
| * @return array Error message. | ||
| */ | ||
| public function getError() { |
Member
Author
There was a problem hiding this comment.
copied this bit from other classes, so i'm assuming it is required?
aristath
requested changes
May 24, 2022
|
|
||
| checkcount(); | ||
|
|
||
| if ( ! preg_match( '/wp_enqueue_script\(\s?("|\')jquery("|\')/i', $php ) ) { |
Member
There was a problem hiding this comment.
This will catch enqueueing jQuery successfully. However, it will not catch cases where jQuery is a dependency of another script - in which case it also gets loaded.
Most themes don't enqueue jQuery directly, it is simply used as a dependency for their own scripts, so we should check for that scenario as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #402