Skip to content

Conversation

@mukeshpanchal27
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/63755

This PR makes a minor update to the way default values are assigned for custom template properties in the get_custom_templates method, using the null coalescing operator for improved readability and consistency.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27 mukeshpanchal27 changed the title Use null coalescing operator in get_custom_templates() Use null coalescing operator in WP_Theme_JSON class methods Oct 2, 2025
@mukeshpanchal27 mukeshpanchal27 self-assigned this Oct 2, 2025
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review October 2, 2025 06:07
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mukesh27, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter
Copy link
Member

Is Core-63755 the right ticket? This doesn't seem to be a performance improvement.

@mukeshpanchal27
Copy link
Member Author

Closing in favour of #4886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants