-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Scripts and styles: Remove redundant HTML5 type attributes #10658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts and styles: Remove redundant HTML5 type attributes #10658
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This has a lot of overlap with #10660. |
westonruter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thing of beauty.
Just one little gnat to pluck out, but I'm pre-approving.
Co-authored-by: Weston Ruter <westonruter@gmail.com>
This property and method are private and only print an empty string. They are safe to remove.
`SCRIPT`, `STYLE`, and stylesheet `LINK` tags do not require a type attribute since the HTML5 standard was released in 2008. Removing the type attribute simplifies logic and normalizes the produced HTML content. Developed in #10658. Follow-up to [46164]. Props hardikhuptechdev, jonsurrell, dmsnell, westonruter. Fixes #64428. See #59883, #64442. git-svn-id: https://develop.svn.wordpress.org/trunk@61411 602fd350-edb4-49c9-b593-d223f7449a82
`SCRIPT`, `STYLE`, and stylesheet `LINK` tags do not require a type attribute since the HTML5 standard was released in 2008. Removing the type attribute simplifies logic and normalizes the produced HTML content. Developed in WordPress/wordpress-develop#10658. Follow-up to [46164]. Props hardikhuptechdev, jonsurrell, dmsnell, westonruter. Fixes #64428. See #59883, #64442. Built from https://develop.svn.wordpress.org/trunk@61411 git-svn-id: http://core.svn.wordpress.org/trunk@60723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
`SCRIPT`, `STYLE`, and stylesheet `LINK` tags do not require a type attribute since the HTML5 standard was released in 2008. Removing the type attribute simplifies logic and normalizes the produced HTML content. Developed in WordPress/wordpress-develop#10658. Follow-up to [46164]. Props hardikhuptechdev, jonsurrell, dmsnell, westonruter. Fixes #64428. See #59883, #64442. Built from https://develop.svn.wordpress.org/trunk@61411 git-svn-id: https://core.svn.wordpress.org/trunk@60723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Building on #10645 (included here).
Trac ticket: https://core.trac.wordpress.org/ticket/64428
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.