-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update Gutenberg Build tool to include the minified CSS #10685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gutenberg Build tool to include the minified CSS #10685
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
tyxla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
The |
Good catch, that's the commit in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving, pending the fix of the ref to 4856d5d1842.
| }, | ||
| "gutenberg": { | ||
| "ref": "b79bbe25a1b00ce640bfab363f182c678181082f" | ||
| "ref": "dea73b609a80016eb1cf3893ea183fe106a06740" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this LGTM.4856d5d1842 is used, per Jarda's comment,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a branch that is protected and only includes the build changes on top of the previous hash (to avoid bringing any new changes from Gutenberg, let's leave that separate for folks that do the back-porting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explaining this, I retract my comments now 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that makes sense.
Should we come up with some nomenclature for such branches? I suspect it's not the only time we'll push this sort of change, and I don't like the idea of our piling up protected branch names like fix/build-tool-old-hash-do-not-remove-branch in our admin panel with no traceability nor lifetime rules.
Trac ticket: https://core.trac.wordpress.org/ticket/64393
Description
Updates the Gutenberg hash to include WordPress/gutenberg#74380, which fixes the CSS build to generate both minified (.min.css) and non-minified (.css) versions. Previously, Gutenberg only produced a single CSS file, causing 404s when SCRIPT_DEBUG is false (Core expects .min.css files).
Testing