Skip to content

Conversation

@youknowriad
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/64393

Description

Updates the Gutenberg hash to include WordPress/gutenberg#74380, which fixes the CSS build to generate both minified (.min.css) and non-minified (.css) versions. Previously, Gutenberg only produced a single CSS file, causing 404s when SCRIPT_DEBUG is false (Core expects .min.css files).

Testing

  1. Run npm run build:dev
  2. Verify both style.css and style.min.css exist in src/wp-includes/blocks/*/
  3. Test with SCRIPT_DEBUG=true and SCRIPT_DEBUG=false — editor should load correctly in both cases

@youknowriad youknowriad self-assigned this Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props youknowriad, tyxla, jsnajdr, mcsf.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsnajdr
Copy link
Member

jsnajdr commented Jan 6, 2026

The dea73 commit points to somewhere in a branch? The corresponding trunk commit is 4856d5d1842.

@mcsf
Copy link

mcsf commented Jan 6, 2026

The dea73 commit points to somewhere in a branch? The corresponding trunk commit is 4856d5d1842.

Good catch, that's the commit in the extinct (edit: protected) fix/build-tool-old-hash-do-not-remove-branch branch

Copy link

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, pending the fix of the ref to 4856d5d1842.

},
"gutenberg": {
"ref": "b79bbe25a1b00ce640bfab363f182c678181082f"
"ref": "dea73b609a80016eb1cf3893ea183fe106a06740"
Copy link

@mcsf mcsf Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming 4856d5d1842 is used, per Jarda's comment, this LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a branch that is protected and only includes the build changes on top of the previous hash (to avoid bringing any new changes from Gutenberg, let's leave that separate for folks that do the back-porting)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining this, I retract my comments now 🙂

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that makes sense.

Should we come up with some nomenclature for such branches? I suspect it's not the only time we'll push this sort of change, and I don't like the idea of our piling up protected branch names like fix/build-tool-old-hash-do-not-remove-branch in our admin panel with no traceability nor lifetime rules.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61446
GitHub commit: 35313fa

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Jan 6, 2026
@youknowriad youknowriad deleted the update/gutenberg-build-min-css branch January 6, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants