Skip to content

Conversation

@Soean
Copy link
Member

@Soean Soean commented Jan 9, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/63430


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props soean, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soean Thanks for catching these. I believe the changes to wp-content/themes need to be reverted, however. Themes need to be compatible with older versions of PHP. For example, Twenty Twenty-One is requires PHP 5.6 which does not support the null coalescing operator (as it was added in PHP 7.0).

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes PHP code by replacing verbose isset() ternary expressions with the more concise null coalescing operator (??). This is a code quality improvement that makes the codebase more readable while maintaining identical behavior.

Changes:

  • Replaced isset() ternary patterns with the null coalescing operator (??) in 5 files
  • Changes are limited to cases where values are extracted directly without additional function calls

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/wp-includes/post-formats.php Simplified array access with null coalescing for post format string lookup
src/wp-includes/functions.php Simplified array access with null coalescing for image MIME type extraction
src/wp-includes/class-wp-xmlrpc-server.php Simplified array access with null coalescing for MIME type parameter in media library function
src/wp-admin/network/edit.php Simplified superglobal access with null coalescing for action parameter
src/wp-admin/includes/class-wp-comments-list-table.php Simplified multiple superglobal accesses with null coalescing for search, user_id, orderby, and order parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants