-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Use null coalescing operator instead of isset() ternaries #10704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
…ernaries in remaining core files.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Soean Thanks for catching these. I believe the changes to wp-content/themes need to be reverted, however. Themes need to be compatible with older versions of PHP. For example, Twenty Twenty-One is requires PHP 5.6 which does not support the null coalescing operator (as it was added in PHP 7.0).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes PHP code by replacing verbose isset() ternary expressions with the more concise null coalescing operator (??). This is a code quality improvement that makes the codebase more readable while maintaining identical behavior.
Changes:
- Replaced
isset()ternary patterns with the null coalescing operator (??) in 5 files - Changes are limited to cases where values are extracted directly without additional function calls
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/wp-includes/post-formats.php | Simplified array access with null coalescing for post format string lookup |
| src/wp-includes/functions.php | Simplified array access with null coalescing for image MIME type extraction |
| src/wp-includes/class-wp-xmlrpc-server.php | Simplified array access with null coalescing for MIME type parameter in media library function |
| src/wp-admin/network/edit.php | Simplified superglobal access with null coalescing for action parameter |
| src/wp-admin/includes/class-wp-comments-list-table.php | Simplified multiple superglobal accesses with null coalescing for search, user_id, orderby, and order parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Trac ticket: https://core.trac.wordpress.org/ticket/63430
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.