feat: add various shell scripts for bootstrapping, deployment, CI, and infrastructure management.#38
feat: add various shell scripts for bootstrapping, deployment, CI, and infrastructure management.#38pedrorichil wants to merge 4 commits intoWorld-Open-Graph:mainfrom
Conversation
…d infrastructure management.
|
Blocked in this review cycle. Reason:
Required remediation:
After that, this PR can be re-evaluated for merge. |
brunoclz
left a comment
There was a problem hiding this comment.
Blocking security issue remains in infra/scripts/seed-dev.sh: password is passed via CLI argument (), which can be exposed in process listings/history. Please switch back to non-argument secret handling (e.g., or equivalent) and push updated checks.
brunoclz
left a comment
There was a problem hiding this comment.
Blocking security issue remains in infra/scripts/seed-dev.sh: password is passed via CLI argument (-p "${NEO4J_PASSWORD}"), which can be exposed in process listings/history. Please switch back to non-argument secret handling (for example, --env NEO4J_PASSWORD or equivalent) and push updated checks.
brunoclz
left a comment
There was a problem hiding this comment.
Blocking security finding remains in infra/scripts/seed-dev.sh: password is passed via CLI argument (-p "${NEO4J_PASSWORD}"), which can leak via process inspection. Please restore non-argument secret handling (e.g., --env NEO4J_PASSWORD) for both local and docker exec paths, then rerun checks.
brunoclz
left a comment
There was a problem hiding this comment.
Blocking findings remain: (1) security regression in seed script still passes password via CLI arg (-p "${NEO4J_PASSWORD}"), which can leak via process inspection; (2) latest checks also include red Pip Audit (Python deps) under strict no-red policy. Please restore non-argument secret handling (--env NEO4J_PASSWORD-style) and re-run checks to green.
brunoclz
left a comment
There was a problem hiding this comment.
Checks are now green, but this PR is still blocked by a security regression in infra/scripts/seed-dev.sh: password is passed via CLI argument (-p "${NEO4J_PASSWORD}") in both code paths, which can leak via process inspection. Please restore non-argument secret handling (--env NEO4J_PASSWORD or equivalent) and push an updated diff.
brunoclz
left a comment
There was a problem hiding this comment.
Blocking security regression remains in infra/scripts/seed-dev.sh: password is passed via CLI argument (-p "${NEO4J_PASSWORD}") in both execution paths. Please restore non-argument secret handling (--env NEO4J_PASSWORD-style) before merge.
|
Policy decision for cycle dated 2026-03-06: refused for merge in this cycle and kept open. Current blockers:
Unblock criteria for reconsideration:
No merge will be performed until all criteria above are met. |
|
Maintainer triage on March 7, 2026: refused for merge in this cycle and kept open. Blockers:
Required next step: restore non-argument secret handling, clear the blocking review state, and push an updated branch for re-evaluation. |
|
@pedrorichil I believe the right approach here is to actually omit the -p flag and let cypher-shell retrieve it directly from the environment on its own. |
No description provided.