Add Multiple Modifier Key Support for Activation Hotkeys#5
Open
O-mkar wants to merge 2 commits intoWorldOfBasti:masterfrom
Open
Add Multiple Modifier Key Support for Activation Hotkeys#5O-mkar wants to merge 2 commits intoWorldOfBasti:masterfrom
O-mkar wants to merge 2 commits intoWorldOfBasti:masterfrom
Conversation
- AutoClicker: add activationModifiers computed property reading ActivationModifiers from UserDefaults; replace inline key check with matchesActivationKey() that verifies both key code and modifier state (Command/Option/Shift/Control only) - KeyCodeToCharTransformer: read ActivationModifiers from UserDefaults and prepend standard macOS symbols (⌃⌥⇧⌘) to the displayed key character - KeyPopoverViewController: update delegate protocol to pass NSEvent.ModifierFlags alongside keyCode; filter to relevant modifiers before forwarding - MainViewController: update keySelected() to save relevant modifiers to ActivationModifiers before saving ActivationKey (IB binding triggers display update) - Fix pre-existing bug: right mouse-up event was incorrectly sending leftMouseUp Made-with: Cursor
IB binding only re-evaluates KeyCodeToCharTransformer when ActivationKey changes. Removing the key before re-setting forces a value change even when the same key code is reused with different modifiers (e.g. 4 -> Shift+4). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Multiple Modifier Key Support for Activation Hotkeys
🎯 Overview
Added support for modifier keys (⌘ Command, ⌥ Option, ⇧ Shift, ⌃ Control) in combination with activation hotkeys, enabling more flexible and conflict-free hotkey configurations.
✨ What's New
Previously, users could only set single keys (e.g., "4") as activation hotkeys. Now you can use modifier combinations like:
⇧4(Shift + 4)⌘C(Command + C)⌃⌥⇧A(Control + Option + Shift + A)🔧 Changes
Modified Files
MainViewController.swiftKeyCodeToCharTransformer.swiftKeyPopoverViewController.swiftKey Features
📋 Technical Details
New Data Storage