Feat: support for tuple types, structs, and enum variants, as well as generics in tuples #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes issue Wulf#46
Collaborator
Author
|
I'm not 100% sure the implementation of adjacent tagging is correct for non-tuple variants, but it is correct for tuple variants |
closes [feature request] Tuples Wulf#43
AnthonyMichaelTDM
force-pushed
the
issue-58-43
branch
from
e89c325 to
01f56be
Compare
Owner
|
Breaking this down into commits and those tests are much appreciated, thanks Anthony! I'll try to give this a look on the weekend. |
Collaborator
Author
|
lmk if we want that empty-object type thing to be optional (enabled by a cli argument or something) |
Collaborator
Author
|
Huh, there's something wrong with the gh action itself |
also, use Swatinem/rust-cache instead of actions/cache
AnthonyMichaelTDM
changed the title
Collaborator
Author
|
Anything else I need to do for this to be merged? |
Owner
|
hey Anthony, thanks again for this and super sorry for being late here. Let me add you as a maintainer. |
Owner
|
published in 2.3.0 |
Owner
|
Added you as a collaborator :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43
fixes #46
fixes #58 ?
addresses #55