Open
Conversation
rbnswartz
requested changes
Aug 15, 2019
Member
rbnswartz
left a comment
rbnswartz
left a comment
There was a problem hiding this comment.
I know you're making changes to this already so just add these to the list.
| /// <returns></returns> | ||
| private JObject retrieveBibleMetadata() | ||
| { | ||
| string jsonData = File.ReadAllText(@"./MetaData.json"); |
Member
There was a problem hiding this comment.
This should probably be configurable in some way. Generally hard-coded file names are a bad idea.
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Update="MetaData.json"> |
Member
There was a problem hiding this comment.
metadata is metadata and not MetaData
| /// Retrieves Bible metadata from local json file (MetaData.json) | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| private JObject retrieveBibleMetadata() |
Member
There was a problem hiding this comment.
I would serialize this to an object instead of just using JObject. You know what the data is going to be like and that will remove a whole list of potential bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.