This repository was archived by the owner on Mar 28, 2022. It is now read-only.
Add ability to manually define item changes#12
Open
P0keDev wants to merge 2 commits intoWynntils:masterfrom
Open
Add ability to manually define item changes#12P0keDev wants to merge 2 commits intoWynntils:masterfrom
P0keDev wants to merge 2 commits intoWynntils:masterfrom
Conversation
|
Seems good to me, other than the potential JSONOrderedObject problem |
Member
Author
|
Realized the current code is not compatible with IDs being added to items, will fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality that merges item changes defined in Data Storage with the Wynncraft API while generating the item list cache. This includes defining completely new items to append to the list.
One potential concern I had is that new items are appended as regular
JSONObjects instead ofJSONOrderedObjects, which means the elements within the item object have different orders. This appears to have no affect on Athena's ability to generate the cache,and as far as I am aware it should not affect Wynntils clients reading the data, but I would appreciate confirmation on these two things.After testing, I can confirm that the irregular ordering has no effect on the client.