fix: initialize msg to NULL in rcon_receive to avoid UB#259
Open
jmallach wants to merge 1 commit into
Open
Conversation
In rcon_receive(), `msg` is declared but not initialized. There are two
code paths that can leave it indeterminate before it is passed to
msg_terminate():
1. DOOM3/Q4 branch: when the received packet has size <= 2+6+4+1 (i.e.
the payload is too short to contain a useful message), the `if` body
that would assign `msg` is skipped entirely.
2. HW_SERVER branch: when size > PACKET_MAXSIZE the switch breaks out
without setting `msg`.
msg_terminate() guards against NULL (`if (!msg || size <= 0) return
g_strdup("\n")`), so setting `msg = NULL` makes both paths safe and
well-defined.
Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
jmallach
force-pushed
the
fix-rcon-uninitialized-msg
branch
from
July 11, 2026 22:42
62bda44 to
e64521b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rcon_receive(),
msgis declared but not initialized. There are two code paths that can leave it indeterminate before it is passed to msg_terminate():DOOM3/Q4 branch: when the received packet has size <= 2+6+4+1 (i.e. the payload is too short to contain a useful message), the
ifbody that would assignmsgis skipped entirely.HW_SERVER branch: when size > PACKET_MAXSIZE the switch breaks out without setting
msg.msg_terminate() guards against NULL (
if (!msg || size <= 0) return g_strdup("\n")), so settingmsg = NULLmakes both paths safe and well-defined.Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com