Skip to content
This repository was archived by the owner on Apr 3, 2023. It is now read-only.

Conversation

@AroPix
Copy link

@AroPix AroPix commented Aug 30, 2022

  • I significantly removed the lines where the root user is needed, as this is very unsafe.
  • I added the commands for Arch based linux distros to the commands
  • I added a command that mounts /proc instead of auto-mounting it via fstab, this ensures (as example for dailydriver users like me), that everything works fine, because as example mounting a drive through Dolphin doesn't work when processes are hidden.

AroPix added 2 commits August 30, 2022 14:23
- I significantly removed the lines where the root user is needed, as this is very unsafe.
- I added the commands for Arch based linux distros to the commands
- I added a command that mounts `/proc` instead of auto-mounting it via fstab, this ensures (as example for dailydriver users like me), that everything works fine, because as example mounting a drive through Dolphin doesn't work when processes are hidden.
- Added a temporary command for ptrace, so it isn't persistent on reboot, as things break (as example League Of Legends from Lutris)
@XRadius
Copy link
Owner

XRadius commented Sep 6, 2022

Thank you for this PR! There are, unfortunately, a few things that I disagree with in this PR:

  • Performing commands as sudo is equivalent to switching with su and executing them like that. This option is not safer, nor more unsafe. The only risk of switching to su is that you could accidentally run other commands as root. But the guide is written in such a way that every time an action is taken using su, the user has to reboot or is finished with installation. That said, I don't mind the sudo commands, but for consistency sake, keeping everything in su makes sense to me, as the eventual service installation still requires it.
  • Temporary modifications are extremely risky. I understand that your instructions make perfect sense for the experienced Linux user, but for newbies coming in to Linux, it's super easy to take one wrong step and get clapped. To support this scenario, it would make more sense to write a shell script to automate the mount & systemctl start steps. During the installation with service-install.sh, you could generate a service-start.sh and service-stop.sh, to perform the respective steps for starting and stopping. This way, users can simply run the start script and be ensured that no steps have been forgotten, and run the stop script when they've finished playing.

If you're willing to make these modifications, I'll happily merge your work to improve http-driver 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants