nvnetdrv minor fixes #760
Open
nvnetdrv minor fixes #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes for nvnetdrv backend.
nvnetdrv: Add sanity check on RX ring size
I was experimenting with lowering memory footprint and transfers would stall if I set this to below ~45.
This turns about to be exactly how many packets is required to contain a 64k TCP window and because we are 100% zero-copy here LWIP can hold these buffers until the window is finished which can drain the RX ring entirely causing the transfer to stall. (This can still happen when there is multiple TCP windows open at once - this needs some investigation)
nvnetdrv: Fix double free on tcpip input failure
We already setup the custom_free_function, which releases the buffer for us!