Skip to content

NZP-5516 Update tests to remove usage of deprecated NZ API fields #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
the-chris-mitchell merged 4 commits into from
Nov 25, 2025
Merged

NZP-5516 Update tests to remove usage of deprecated NZ API fields #426

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecc11d2
NZP-5516 Update tests to remove usage of deprecated NZ API fields
Xero-Chris-Lelievre Nov 20, 2025
eb94ee7
NZP-5516 Update tests to remove usage of deprecated NZ API fields
Xero-Chris-Lelievre Nov 20, 2025
c53b6cc
NZP-5516 remove deprecated NZ api fields
Xero-Chris-Lelievre Nov 25, 2025
d428cc4
Merge branch 'NZP-5516' of https://github.com/Xero-Chris-Lelievre/Xer…
Xero-Chris-Lelievre Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/com/xero/api/client/PayrollNzApiEmployeeLeaveSetupTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void createEmployeeLeaveSetupTest() throws IOException {

assertThat(response.getLeaveSetup().getHolidayPayOpeningBalance(), is(equalTo(10.0)));
assertThat(response.getLeaveSetup().getAnnualLeaveOpeningBalance(), is(equalTo(100.0)));
assertThat(response.getLeaveSetup().getSickLeaveHoursToAccrueAnnually(), is(equalTo(20.0)));
assertThat(response.getLeaveSetup().getSickLeaveToAccrueAnnually(), is(equalTo(20.0)));
assertThat(response.getLeaveSetup().getSickLeaveOpeningBalance(), is(equalTo(10.0)));

//System.out.println(response.toString());
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/xero/api/client/PayrollNzApiEmployeeLeaveTypesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public void getEmployeeLeaveTypesTest() throws IOException {

assertThat(response.getLeaveTypes().get(0).getLeaveTypeID(), is(equalTo(UUID.fromString("0441497f-5dc7-4cd3-a90d-f2e07e21b2a6"))));
assertThat(response.getLeaveTypes().get(0).getScheduleOfAccrual(), is(equalTo(com.xero.models.payrollnz.EmployeeLeaveType.ScheduleOfAccrualEnum.PERCENTAGEOFGROSSEARNINGS)));
assertThat(response.getLeaveTypes().get(0).getHoursAccruedAnnually(), is(equalTo(0.0)));
assertThat(response.getLeaveTypes().get(0).getUnitsAccruedAnnually(), is(equalTo(0.0)));
assertThat(response.getLeaveTypes().get(0).getMaximumToAccrue(), is(equalTo(0.0)));
assertThat(response.getLeaveTypes().get(0).getOpeningBalance(), is(equalTo(0.0)));
assertThat(response.getLeaveTypes().get(0).getPercentageOfGrossEarnings(), is(equalTo(8.0)));
Expand All @@ -65,7 +65,7 @@ public void createEmployeeLeaveTypesTest() throws IOException {

assertThat(response.getLeaveType().getLeaveTypeID(), is(equalTo(UUID.fromString("35da97ae-05b9-427f-9a98-69157ba42cec"))));
assertThat(response.getLeaveType().getScheduleOfAccrual(), is(equalTo(com.xero.models.payrollnz.EmployeeLeaveType.ScheduleOfAccrualEnum.ANNUALLYAFTER6MONTHS)));
assertThat(response.getLeaveType().getHoursAccruedAnnually(), is(equalTo(10.0)));
assertThat(response.getLeaveType().getUnitsAccruedAnnually(), is(equalTo(0.0)));
Copy link
Contributor Author

@Xero-Chris-Lelievre Xero-Chris-Lelievre Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author: the unitsAccruedAnnually has a value of 0 in the sdk, hence the value update
https://github.com/XeroAPI/Xero-OpenAPI/blob/b12343a7010ef138f893b1ae28662875db276cea/xero-payroll-nz.yaml#L1828

assertThat(response.getLeaveType().getMaximumToAccrue(), is(equalTo(80.0)));
assertThat(response.getLeaveType().getOpeningBalance(), is(equalTo(100.0)));
assertThat(response.getLeaveType().getPercentageOfGrossEarnings(), is(equalTo(0.0)));
Expand Down
Loading