Integrate debug tools into aiebu-dump#265
Open
AdvaitNaik wants to merge 4 commits intoXilinx:main-gefrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates standalone debug tooling into the aiebu-dump utility by adding new “private” modes that extract .dump JSON debug data from supported ELFs and print trace probe listings or opcode metadata.
Changes:
- Add
--private trace-probeand--private opcode-infomodes toaiebu-dump, including new CLI args (--pc,--page-index,--uc-index). - Introduce a new C++
debug_toolshelper plus implementations for trace probe listing and opcode info lookup. - Wire new tool sources into the C++ build and document the new CLI options in the user manual.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cpp/utils/dump/dump.cpp | Adds --private CLI plumbing and dispatch into the new debug tooling. |
| src/cpp/tools/debug_tools.h | Declares the debug_tools helper used to extract cached .dump JSON. |
| src/cpp/tools/debug_tools.cpp | Implements .dump extraction/caching using transform_manager. |
| src/cpp/tools/trace_probe.cpp | Implements trace probe listing output from .dump JSON. |
| src/cpp/tools/opcode_information.cpp | Implements opcode lookup/output by PC + page (+ optional uC). |
| src/cpp/CMakeLists.txt | Adds the new tool sources to the build. |
| AIEBU_USER_MANUAL.rst | Documents new --private modes and arguments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Advait Hemant Naik <advanaik@amd.com>
Signed-off-by: Advait Hemant Naik <advanaik@amd.com>
Signed-off-by: Advait Hemant Naik <advanaik@amd.com>
Signed-off-by: Advait Hemant Naik <advanaik@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
add frequently used standalone python debug tools to aiebu-dump utility
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
NA
How problem was solved, alternative solutions (if any) and why they were rejected
https://amd.atlassian.net/wiki/spaces/AIE/pages/1583345872/Integrate+.dump+debug+map+tools+into+aiebu-dump
Risks (if any) associated the changes in the commit
NA
What has been tested and how, request additional testing if necessary
Documentation impact (if any)
updated - AIEBU_USER_MANUAL