fix: address code review feedback from noctalia-dev maintainer (PR #310)#1
Closed
blackbartblues wants to merge 1 commit intoXimoCP:mainfrom
Closed
fix: address code review feedback from noctalia-dev maintainer (PR #310)#1blackbartblues wants to merge 1 commit intoXimoCP:mainfrom
blackbartblues wants to merge 1 commit intoXimoCP:mainfrom
Conversation
- Add Main.qml with IpcHandler and toggle() for keybind support
- Rename plugin to "Hyprland Visual Layer", add hyprland tag
- Replace all console.log/error with Logger.i/e
- Remove custom tr() wrappers, use pluginApi?.tr() directly
- Replace hardcoded Quickshell.env("HOME") paths with Settings.configDir
- Add Component.onDestruction cleanup for all Process objects
- Fix BarWidget: openPanel() → togglePanel(), remove broken Settings menu
- Replace all hardcoded spacing values with Style.margin* constants
- Remove unused runHypr property from all modules
- Remove orphaned widget.menu_settings key from all i18n files
- Translate all Spanish comments and fallback strings to English
- Guard scanner startup against empty pluginDir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes raised by maintainer ItsLemmy in noctalia-dev/noctalia-plugins#310.
Hyprland Visual Layer, addedhyprlandtag in manifestIpcHandlerwithtoggle()for keybind compatibility;pluginDirresolved viaSettings.configDir(portable path, no hardcoded$HOME)tr()wrappers from all modules — now usespluginApi?.tr("key") || "fallback"everywhereconsole.log/console.errorreplaced withLogger.i/Logger.eopenPanel()→togglePanel()(correct pluginApi method); removed non-functional Settings context menuComponent.onDestructiontoPanel.qml,AnimationModule,BorderModule,ShaderModuleto terminate bash processesStyle.marginXXS/Style.marginXS/Style.marginS/Style.marginM/Style.marginLpluginDiron startup; re-run viaonPluginDirChangedrunHypr: nullunused property; removed orphanedwidget.menu_settingsi18n key from all 16 language files; removedfont.family: Style.fontMono(property doesn't exist)Test plan
qs ipc call plugin:noctalia-visual-layer togglekeybind works