Use BEVY_ASSET_ROOT & CARGO_MANIFEST_DIR to load yarn file

[Galdormin]

To solve #271, register_asser_root needs to take into account the absolute path that may be included through BEVY_ASSET_ROOT or CARGO_MANIFEST_DIR.

The only way I found to solve this is to use the FileAssetReader which is not available in wasm32 builds.

Or we could integrate part of get_base_path inside register_asset_root() as in:

fn register_asset_root(&mut self) -> &mut Self {
    let asset_plugin = get_asset_plugin(self);
    let path_str = asset_plugin.file_path.clone();

    let path = if let Ok(manifest_dir) = env::var("BEVY_ASSET_ROOT") {
        let mut root_path = PathBuf::from(manifest_dir);
        root_path.push(path_str);
        root_path
    } else if let Ok(manifest_dir) = env::var("CARGO_MANIFEST_DIR") {
        let mut root_path = PathBuf::from(manifest_dir);
        root_path.push(path_str);
        root_path
    } else {
        PathBuf::from(path_str)
    };

    self.insert_resource(AssetRoot(path))
}

However, I'm not an expert in wasm32 build and I don't know if std::env is available there.

Which version do you prefer ?

[janhohenheim]

@andriyDev mind helping me out here for a second?

[andriyDev]

Overall I think this is fine! I think calling get_base_path is better than forking this for sure (to stay in sync).

[andriyDev]

Can we only conditionally compile these two lines instead of the whole function? I think it's simpler that way (than acting like these are totally different).

[Galdormin]

Something like this ?

fn register_asset_root(&mut self) -> &mut Self {
    let asset_plugin = get_asset_plugin(self);
    let path_str = asset_plugin.file_path.clone();

    #[cfg(not(target_arch = "wasm32"))]
    let path = FileAssetReader::get_base_path().join(path_str);
    #[cfg(target_arch = "wasm32")]
    let path = PathBuf::from(path_str);

    self.insert_resource(AssetRoot(path))
}

[andriyDev]

Yeah I think that'll work!

[Galdormin]

Not tested on wasm32 though