Conversation
I kept forgetting to include comments that might help someone understand my code... here's the final version!
|
Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions. doge_poetry.py, line 14 [r1] (raw file): doge_poetry.py, line 28 [r1] (raw file): doge_poetry.py, line 92 [r1] (raw file): Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a bunch of changes to my original code! Jennifer suggested creating a clean_gutenberg_text function, and in addition to that, I decided to make a few more changes (namely, making the poem generator loopable and implementing an option for the user to feed the doge a treat to get better poems).
I hope you enjoy this as much as I did!