Skip to content
This repository was archived by the owner on Oct 16, 2025. It is now read-only.

Conversation

@olgabot
Copy link
Collaborator

@olgabot olgabot commented Feb 4, 2015

  • Interactive classifier saving: interactive_classifier savefile doesn't work #218
  • Interactive PCA saving
  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage. To run code coverage on only the file you changed,
    for example flotilla/compute/splicing.py, use this command:
    py.test --cov flotilla/compute/splicing.py --cov-report term-missing flotilla/test/compute/test_splicing.py
    which will show you which lines aren't covered by the tests.
  • Do the new functions have descriptive
    numpydoc
    style docstrings?
  • If it adds a new plot, is it documented in the gallery?
  • Is it well formatted? Look at make pep8 and make lint output
  • Is it documented in the doc/releases/?
  • Was a spellchecker run on the source code and documentation after changes were made?

mlovci and others added 30 commits January 10, 2015 16:44
olgabot added 23 commits March 12, 2015 15:59
…uring _filename_from_resource but can't use non-staticmethod methods on an uninstantiated class
…otting features to be documented as ipython notebooks and added to the tutorial
Add requirement for non-plotting examples to be documented as ipython notebooks
* origin/master: (77 commits)
  Add finished supplementaldata ipynb
  Add option and test for user-specified flotilla directory
  fix pep8
  Get supplemental resource name, not name of supplemental
  fix resource --> supplemental in reading all supplemental data
  actually iterate over the items of name_to_df
  Clarify where example plots should go, add requirement for new non-plotting features to be documented as ipython notebooks and added to the tutorial
  initial addition of ipynb for supplementaldata
  move _is_absolute_path to not a method of Study because it's needed during _filename_from_resource but can't use non-staticmethod methods on an uninstantiated class
  Add test for embarking on a datapackage with supplemental data
  Add supplemental data to reading/loading of the datapackage
  Add newline to sys.stdout message
  pep8 fixes
  add release notes
  Add release notes
  lint fixes
  pep8 fixes (hopefully will fix failing tests)
  initial tests of supplemental seem to work
  remove "_fixed", "_no_na" fixtures
  initial commit of supplemental data
  ...
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 52.58% when pulling ab69a62 on interactive_fixes into fc88ff0 on master.

@jasongrout
Copy link

Sorry, I didn't see your note until just now. With IPython, we test interactive things with a casperjs-based test suite that tests the whole chain (sets up a notebook server, runs javascript, and then tests the results of the user actions in the browser). It's messy, but it works and gives us end-to-end tests.

@olgabot
Copy link
Collaborator Author

olgabot commented Mar 26, 2015

Jason, thanks for the response! I know you're busy. I'll have to take a
look at that casperjs system to see how this can be integrated. Do you have
a favorite example in the test suite?

On Thu, Mar 26, 2015 at 8:24 AM Jason Grout notifications@github.com
wrote:

Sorry, I didn't see your note until just now. With IPython, we test
interactive things with a casperjs-based test suite that tests the whole
chain (sets up a notebook server, runs javascript, and then tests the
results of the user actions in the browser). It's messy, but it works and
gives us end-to-end tests.


Reply to this email directly or view it on GitHub
#258 (comment).

@jasongrout
Copy link

No, I don't have any favorite examples in the ipython js test suite. They're all complicated and not very intuitive :). But you can look here for some examples: https://github.com/ipython/ipython/tree/master/IPython/html/tests/widgets

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants