Fix location of lang files to prevent applications with localization from breaking#9
Open
michaelklopf wants to merge 3 commits intoYieldStudio:mainfrom
Open
Fix location of lang files to prevent applications with localization from breaking#9michaelklopf wants to merge 3 commits intoYieldStudio:mainfrom
michaelklopf wants to merge 3 commits intoYieldStudio:mainfrom
Conversation
|
upvote |
|
upvote |
1 similar comment
|
upvote |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel moved the language files with version 9 from the
/resources/langfolder to the/langfolder.Running the
php artisan vendor:publish --provider="YieldStudio\NovaGoogleAutocomplete\FieldServiceProvider"command creates files in the/resources/langfolder.The default lang path in Laravel is
/lang. Laravel checks if any files reside in/resources/langand changes the lang path to/resources/langif this is true.This breaks the existing application as it can't find language files in
/langanymore.This PR fixes where the files are placed, how they are retrieved and adapts the documentation.
close #10