Fix: world.addEventHandler() takes Lua table, not a function#15
Merged
Conversation
…#13) - Add EventHandlerTable type to define the expected table structure with onEvent method - Update world.addEventHandler() to accept EventHandlerTable instead of function - Update world.removeEventHandler() to accept EventHandlerTable instead of function - Fix function descriptions to accurately reflect DCS World API behavior The functions now correctly expect a table containing an onEvent method rather than a direct function parameter.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the world event handler API to require an EventHandlerTable with an onEvent method instead of a bare function to align with the DCS World API behavior.
- Introduces the EventHandlerTable type in the Event.types.yaml file.
- Updates the parameter types and descriptions in world.singleton.yaml for addEventHandler and removeEventHandler.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dcs-world-schema/types/Event.types.yaml | Adds a new EventHandlerTable record type with an onEvent field. |
| dcs-world-schema/globals/world.singleton.yaml | Updates event handler function parameters to use EventHandlerTable. |
DCS Schema Stats
✅ All validation checks passed! |
DCS Schema Stats
✅ All validation checks passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#13)
The functions now correctly expect a table containing an onEvent method rather than a direct function parameter.