Correct coalition.addStaticObject parameter count and return type#16
Merged
YoloWingPixie merged 1 commit intoMay 24, 2025
Conversation
#14) - Remove incorrect coalition.side parameter - DCS automatically infers coalition from country identifier - Update return type from function to StaticObject to match actual DCS World API behavior - Update method description to clarify coalition is determined automatically Fixes crash reported where function was defined with incorrect parameter count. The function should only take (country.id, StaticObjectSpawnData
DCS Schema Stats
✅ All validation checks passed! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the coalition.addStaticObject schema with the actual DCS World API by removing an unused parameter and correcting its return type, then bumps the package version and updates the changelog.
- Remove the incorrect
coalitionparameter fromaddStaticObject - Update return type from
functiontoStaticObject - Bump version to 0.3.3 and document the fixes in CHANGELOG.md
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dcs-world-schema/globals/coalition.singleton.yaml | Removed the coalition param, updated the method description, and changed the return type to StaticObject. |
| VERSION | Updated version number from 0.3.2 to 0.3.3. |
| CHANGELOG.md | Added a new section for [0.3.3] with details on the removed parameter and return type update. |
Comments suppressed due to low confidence (2)
dcs-world-schema/globals/coalition.singleton.yaml:52
- No tests were updated to reflect the new
addStaticObjectsignature and return type. Please add or update unit tests to cover the updated behavior ofcoalition.addStaticObject.
returns: StaticObject
dcs-world-schema/globals/coalition.singleton.yaml:53
- [nitpick] Since the signature and return type of
addStaticObjectwere updated in this release, consider adding achangedVersion: "0.3.3"or annotating the change in the schema to improve clarity.
addedVersion: "1.2.0"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #14
coalition.sideparameter - DCS automatically infers coalition from country identifiertaticObjectto documented actual DCS World API behaviorFixes crash reported where function was defined with incorrect parameter count. The function should only take (country.id, StaticObjectSpawnData