fix: showMessageBox is an optional param for env logging functions#18
Merged
YoloWingPixie merged 1 commit intoMay 25, 2025
Conversation
DCS Schema Stats
✅ All validation checks passed! |
YoloWingPixie
deleted the
17-env-logging-functions-show-param-showmessagebox-as-being-required-should-be-optional
branch
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adjusts the schema to mark the showMessageBox parameter as optional for all env logging methods and updates project metadata for a new patch release.
- Mark
showMessageBoxas optional inenv.info,env.warning, andenv.error - Bump version from 0.3.3 to 0.3.4
- Add changelog entry for release 0.3.4
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dcs-world-schema/globals/env.singleton.yaml | Add optional: true to showMessageBox param for logging methods |
| VERSION | Update version number to 0.3.4 |
| CHANGELOG.md | Add 0.3.4 release notes |
| @@ -12,6 +12,7 @@ globals: | |||
| - name: showMessageBox | |||
There was a problem hiding this comment.
[nitpick] The showMessageBox parameter block is duplicated for each log function. Consider using a YAML anchor or reference to avoid repetition and simplify future updates.
Suggested change
| - name: showMessageBox | |
| - &showMessageBox | |
| name: showMessageBox |
| ## [Unreleased] | ||
|
|
||
| ## [0.3.4] - 2025-05-25 | ||
| - Resolved #17 - `env` logging functions (`env.info`, `env.error`, `env.warning`) incorrectly show param `showMessageBox` as being required. |
There was a problem hiding this comment.
[nitpick] The changelog entry uses 'Resolved' while earlier versions use a 'Fixed' section header. For consistency, align this entry with the existing style (e.g., use 'Fixed').
Suggested change
| - Resolved #17 - `env` logging functions (`env.info`, `env.error`, `env.warning`) incorrectly show param `showMessageBox` as being required. | |
| - Fixed #17 - `env` logging functions (`env.info`, `env.error`, `env.warning`) incorrectly show param `showMessageBox` as being required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.