only run this.search() when a query is set#58
Open
joshbedo wants to merge 3 commits intoYousefED:masterfrom
Open
only run this.search() when a query is set#58joshbedo wants to merge 3 commits intoYousefED:masterfrom
joshbedo wants to merge 3 commits intoYousefED:masterfrom
Conversation
Owner
Thanks, |
Author
|
Cool i can make those changes. Everything else make sense? I'll create some method like |
aedaea1 to
7b67bda
Compare
added 2 commits
October 19, 2015 11:45
added isQuerySet() method to reduce redundancy
7b67bda to
f9d0976
Compare
Author
|
Just made changes let me know if everything looks alright. |
Owner
|
Hi, I didn't mean moving the null checks to a separate method. I meant can't we have 1 check further down / up in the call stack and thus centralize the logic? |
Author
|
ahh okay, sorry i misunderstood. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.