Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileBrowser v2.44.0 - Port 80 Optimization for Clean NSL URLs
Summary
Optimizes FileBrowser configuration for NSL Router with explicit port 80 declaration, resulting in clean HTTPS URLs without port numbers.
Changes
Version
Port Configuration Enhancement
Before
After
Result:
https://80-filebrowser-[username].nsl.sh(potential)https://filebrowser-[username].nsl.sh✅ Clean!NSL Router Integration
By explicitly setting
webui_port: 80, the NSL Router generates clean URLs without port prefixes:3000-appname)Asset URLs Updated
All assets now point to main Yundera repository:
Configuration Details
Pre-install Commands (Unchanged)
Security Compliance:
User & Permissions
Rationale:
Volume Mappings
User-Friendly Directories: All mounted with user access
Resource Configuration
Rationale:
Testing Performed
✅ Fresh Installation
✅ Uninstall/Reinstall
✅ NSL Router Access
https://filebrowser-[username].nsl.sh✅ Clean!✅ Functionality
✅ Permissions
Checklist
Security ✅
Functionality ✅
Documentation ✅
Files Changed
Modified
Apps/FileBrowser/docker-compose.ymlwebui_port: 80declarationUser Impact
✅ Improvements
📖 No Breaking Changes
Before vs After
Before
After
Breaking Changes
None
Migration Notes
No migration required - Configuration optimization only
Additional Context
Why Explicit Port Declaration Matters
FileBrowser Features (Unchanged)
Related Applications
Works well with:
Tested Environment:
Ready for Review ✅