Merged
Conversation
Big issue: go hangs on dlopen, rust doesn't
In future PRs if someone were to ever build a module, we wouldn't be able to confirm if the module is directly from that code, or if it features some malware. So it's best to simply not to include the built modules and instead make the dev build it themself
Now need to get rest of Pixel Jumble working, maybe also improve the TypeScript FFI class
Only need to add hints now
Now only need an answering system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comes with a FFI module for generating a 3x3 chart image in Rust.
Adding Rust does add an additional build step, so we'll include in our builds the modules.