Skip to content

Update to membrane_core v1.2#29

Open
varsill wants to merge 3 commits into
YuzuTen:mainfrom
membraneframework-labs:update_to_new_core
Open

Update to membrane_core v1.2#29
varsill wants to merge 3 commits into
YuzuTen:mainfrom
membraneframework-labs:update_to_new_core

Conversation

@varsill
Copy link
Copy Markdown

@varsill varsill commented Apr 3, 2026

Hello @JasonTrue !

This PR:

  • adjusts the Membrane.S3.Sink element to API provided by membrane_core v1.2
  • updates dependencies of the package
  • makes ex_doc only :dev dependency, with runtime: false
  • makes Membrane.S3.Sink use pads with :auto flow control
  • adjusts the tests accordingly

As far as I can see it has been quite a while since the last activity in this repository - if you feel like you don't have capabilities or desire to maintain this repository, Membrane team we will be happy to have it transfered to github.com/membraneframework organization and maintain it ;)
We will surely be happy to contribute more to the repository as well, as we plan to use S3 with a forthcoming tutorial.

@JasonTrue
Copy link
Copy Markdown
Member

Thank you for the patch. The project I originally built this plugin for was canceled, so I haven't had the luxury of keeping up with the Membrane SDK updates.

I am away from my laptop tonight but I'll try to finish reviewing the PR sometime in the next 24 hours.

I am amenable to the option of moving the repo to the core membrane framework. I'd planned to add a S3 source as well but didn't have time. Let me know what documents are required to facilitate a transfer.

@varsill
Copy link
Copy Markdown
Author

varsill commented Apr 7, 2026

Hello @JasonTrue ! Thanks for a quick response.
Sure, take your time when it comes to reviewing the PR, we are not in a hurry ;)

I'd planned to add a S3 source as well but didn't have time.

Actually we have a kind of a POC of S3 sink, capable of reading particular byte ranges of an object. It requires some further development but it would be a good starting point.

Let me know what documents are required to facilitate a transfer.

AFAIK it would be sufficient to transfer the ownership to the https://github.com/membraneframework/ organization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants