feat: add auto-borderless apps, startup options and admin elevation#3
feat: add auto-borderless apps, startup options and admin elevation#3lava1879 wants to merge 3 commits intoZ1xus:mainfrom
Conversation
- add "Automatically make borderless" checkbox for selected windows - persist auto-borderless app list in config (ihateborders_config.json) - add settings window with option to run ihateborders on windows startup - add option to launch at startup with administrator privileges (using scheduled task with highest privileges) - fix ui refresh issues: button text and auto-checkbox now update instantly - improve overall responsiveness and visual feedback
|
|
hi, thank you for contributing! this looks like a good start for auto-borderless. i have a few thoughts on how we can polish this up:
|
|
hi, i've already implemented tray-icon, but i was having issues with launching it minimized, im also not a huge fan of the way I've made the app start on login using a scheduled task, which i plan to change. i'll look into your config suggestion, and see what i can do. |
| let windows = self.window_manager.get_windows().to_vec(); | ||
|
|
||
| for window in windows.iter() { | ||
| if self.config.is_auto_borderless(&window.process_name) |
There was a problem hiding this comment.
do you think we could use the full executable path instead? it would help avoid issues if two different apps happen to have the same name
|
i noticed the chosen display isn't being saved in the config. for automation to really work, we should probably store which monitor each app belongs to so it doesn't just default to display 0 on every restart |
i'll work on that. for now, here's a small sneek peek of tray-icon, the icon is a bit blurry (i used icon.ico under assets) so that probably needs a bit of work. i'm considering removing the top text that says ihateborders, what do you think? 
|
2 participants
related issue: #2