Show typographically correct sharp symbol in the UI and accept it when finding frequency

[maximal]

Description

Use typographically correct C♯, D♯, F♯, G♯, A♯ alongside the simplified C#, D#, F#, G#, A# variants.

Acknowledgments

By submitting this pull request, I acknowledge and confirm the following:

• If this is not a multilingual/localization support pull request, I confirm that this feature, fix, or change has been discussed and aligned upon in the repository's Discussions section prior to opening this PR.
• I agree that all code contributed through this pull request is licensed under the Apache-2.0 License.
• I certify that I am the sole author and legal owner of this code, or that I have the necessary rights and permissions to contribute it under the specified license without violating any third-party intellectual property.
• I have manually reviewed this code and verified its functionality.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[zsliu98]

The symbol ♯ is not supported by Inter, which is the font used by the plugin. As # should be understandable to most people, I don't see a strong reason to change the font for this.

[maximal]

@zsliu98, I made the getFrequencyFromNote() function Unicode-aware too.

You can use it, if you like:

        for (char& c : note_part) {
            if (c >= 'a' && c <= 'g') {
                c = static_cast<char>(std::toupper(static_cast<unsigned char>(c)));
            }
        }

        int note_index = -1;
        for (int i = 0; i < static_cast<int>(kNoteNames.size()); ++i) {
            if (
                kNoteNames[static_cast<size_t>(i)] == note_part ||
                kNoteNamesAlt[static_cast<size_t>(i)] == note_part
            ) {
                note_index = i;
                break;
            }
        }

[maximal]

Also, I checked Inter in Figma before creating the pull request:

Seems like the sharp symbol is supported.

[zsliu98]

Also, I checked Inter in Figma before creating the pull request:

Seems like the sharp symbol is supported.

Thanks for testing that. I can also see that in Figma. But in Google Font page it shows as not supported: https://fonts.google.com/specimen/Inter?specimen.preview.text=%E2%99%AF

I need to find out where they are not consistent with each other ...

[zsliu98]

I can confirm that ♯ (U+266F) is missing from Inter, as it is not included in https://github.com/rsms/inter/blob/353b61b9f4430d5f420d56605a6e7993e0941470/docs/lab/glyphinfo.json

Fimga seems to use a fallback font silently (or a customized Inter font?), both on the webpage https://www.figma.com/fonts/inter/ and the app.