Harden conversion failure containment (salvaged from PR #1) - #2
Open
ZaidNAlAsali wants to merge 1 commit into
Open
Harden conversion failure containment (salvaged from PR #1)#2ZaidNAlAsali wants to merge 1 commit into
ZaidNAlAsali wants to merge 1 commit into
Conversation
Salvaged narrow hardening hunks from the draft PR #1 branch onto integration: - Conversion jobs fail closed: missing input extension is rejected cleanly, sub-job cancels are null-safe, CD drive is always released via finally, intermediate files are never deleted while a thread still uses them, and post-conversion actions are exception-guarded. - Settings and presets are null-safe on deserialization, language culture falls back instead of throwing, preset import validates the file and reports failures instead of continuing blind. - Explorer extension: registry and preset reads are null-guarded, process start failures surface a message and clean up the temp input list, URL opening is guarded. - DebugInstaller.bat uses the ZFileConverter MSI paths. Verified: MSBuild Release x64, 0 warnings, 0 errors; produces ZFileConverter-setup.msi.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of the narrow hardening hunks from the closed draft PR #1, applied on top of integration (v2.3.2).
What this includes
What this deliberately does not include
Verification