Skip to content

Bug uvlf binned recursive dusting#32

Merged
JulianBMunoz merged 2 commits into
ZeusCosmo:mainfrom
ebregou:bug-UVLF-binned-recursive-dusting
Jun 9, 2025
Merged

Bug uvlf binned recursive dusting#32
JulianBMunoz merged 2 commits into
ZeusCosmo:mainfrom
ebregou:bug-UVLF-binned-recursive-dusting

Conversation

@ebregou
Copy link
Copy Markdown
Contributor

@ebregou ebregou commented Jun 9, 2025

Fixed a bug in the UVLF code (dust attenuation)

ebregou added 2 commits June 9, 2025 14:01
This section of the code is made to apply dust recursively to the UVLF until convergence is reached. The bug made it such that dust would only be applied once (since currMUV2 would be equal to currMUV by definition). This branch fixes the bug and ensures the intended behavior of this process.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.11%. Comparing base (707f0ce) to head (02bafe6).
⚠️ Report is 5 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   73.11%   73.11%           
=======================================
  Files           9        9           
  Lines        1700     1700           
=======================================
  Hits         1243     1243           
  Misses        457      457           
Flag Coverage Δ
unittests 73.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
zeus21/UVLFs.py 84.50% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707f0ce...02bafe6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JulianBMunoz JulianBMunoz merged commit 9ea7c39 into ZeusCosmo:main Jun 9, 2025
1 check passed
@ebregou ebregou deleted the bug-UVLF-binned-recursive-dusting branch November 5, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants