Major refactor moving things to the render thread#73
Draft
ZigyTheBird wants to merge 4 commits intomainfrom
Draft
Major refactor moving things to the render thread#73ZigyTheBird wants to merge 4 commits intomainfrom
ZigyTheBird wants to merge 4 commits intomainfrom
Conversation
Owner
Author
|
Less chance of concurrent modification exceptions because everything is on the same thread |
Collaborator
|
I looked, didn't like it, next time I'll look at it when it's REALLY necessary. |
Owner
Author
|
Thank you, sounds good |
dima-dencep
requested changes
Dec 20, 2025
core/src/main/java/com/zigythebird/playeranimcore/animation/AnimationController.java
Show resolved
Hide resolved
core/src/main/java/com/zigythebird/playeranimcore/animation/AnimationController.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/zigythebird/playeranimcore/animation/AnimationData.java
Show resolved
Hide resolved
minecraft/common/src/main/java/com/zigythebird/playeranim/mixin/AvatarMixin.java
Show resolved
Hide resolved
minecraft/common/src/main/java/com/zigythebird/playeranim/mixin/LevelRendererMixin.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once again, don't be mean if you don't like it!
I just feel like this is a good step towards future proofing things