Open
Conversation
|
|
tmclane
reviewed
May 10, 2018
| cd $(psrctmp)/$(pname)-$(pvers)-zimbra/modules && \ | ||
| git clone https://github.com/synacor/nginx-module-txid120 >/dev/null 2>&1 && \ | ||
| cd nginx-module-txid120 && \ | ||
| rm -rf .git |
Contributor
There was a problem hiding this comment.
Perhaps a git archive might be useful here?
Contributor
There was a problem hiding this comment.
Yes we want to make sure we control exactly which version we are pulling in and have tested.
tmclane
approved these changes
May 10, 2018
thefoolwhocodes
approved these changes
Jul 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the txid120 module to allow the generation of unique transaction identifiers to inbound requests.