Compatibility with fabrishot (and possibly other mods)#72
Open
OffsetMonkey538 wants to merge 1 commit intoZolo101:1.21.9from
Open
Compatibility with fabrishot (and possibly other mods)#72OffsetMonkey538 wants to merge 1 commit intoZolo101:1.21.9from
OffsetMonkey538 wants to merge 1 commit intoZolo101:1.21.9from
Conversation
Author
|
There is a PR on the Fabrishot repo as well because both mods need changes: ramidzkh/fabrishot#125 |
Owner
|
Thank you for the PR! And yeah this'll definitely help with mod support. I'll merge this very soon & release a fix for 1.21.11! As for backports I'm currently converting this mod to use Stonecutter to make adding features for all versions easier. Once I'm done with that I will add this fix to the rest of the versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
Makes use of the @ModifyReturnValue injector from MixinExtras to change window size. This way the target method won't be immediately cancelled and other mods may modify the window size further.