Skip to content

[Feat] Integrate DCG with command auto-approval and denial UX - #1062

Open
navedmerchant wants to merge 1 commit into
feat/dcg-settingfrom
feat/dcg-command-integration
Open

[Feat] Integrate DCG with command auto-approval and denial UX#1062
navedmerchant wants to merge 1 commit into
feat/dcg-settingfrom
feat/dcg-command-integration

Conversation

@navedmerchant

Copy link
Copy Markdown
Contributor

Related GitHub Issue

Closes #1058
Completes #1049. Split from #1050.

Description

Completes the feature at the command approval boundary. DCG-approved commands can bypass the legacy allowlist only when command auto-approval and DCG are enabled. DCG-blocked commands are protected and require explicit approval. Disabling DCG preserves existing behavior. Localized reason/rule feedback and a dedicated denied-command chat state are included.

A user can still explicitly approve a DCG-blocked command; denying it does not execute it.

Stack

4 / 4 — base: feat/dcg-setting

The complete stack tip is tree-identical to the original #1050 branch, so no original change was dropped.

Test Procedure

pnpm --dir src exec vitest run core/auto-approval/__tests__/dcg.spec.ts core/tools/__tests__/executeCommandTool.spec.ts
pnpm --dir packages/types exec vitest run src/__tests__/message.test.ts
pnpm --dir webview-ui exec vitest run src/components/chat/__tests__/ChatRow.command-denied.spec.tsx src/components/chat/__tests__/CommandExecution.spec.tsx
pnpm --dir packages/types check-types
pnpm --dir src check-types
pnpm --dir webview-ui check-types
pnpm --dir src bundle
pnpm --dir webview-ui build

Result: 41 extension, 7 type-package, and 40 webview tests passed; type-checks, production builds, lint, pre-push checks, and i18n validation passed.

Checklist

  • Safety boundary covered by tests
  • DCG-disabled behavior preserved
  • Denied UX and localization included
  • Type-check/build/lint passing

@navedmerchant navedmerchant added the enhancement New feature or request label Jul 30, 2026
@navedmerchant navedmerchant added the enhancement New feature or request label Jul 30, 2026
@navedmerchant navedmerchant self-assigned this Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 70c7ab5d-cb77-470f-873a-1ac874af8294

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/tools/ExecuteCommandTool.ts 83.33% 2 Missing and 2 partials ⚠️
src/core/task/Task.ts 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Jul 30, 2026
@navedmerchant
navedmerchant force-pushed the feat/dcg-command-integration branch from 3e1b109 to 5f6e0a8 Compare July 30, 2026 04:50
@github-actions github-actions Bot added awaiting-review PR changes are ready and waiting for maintainer re-review and removed awaiting-review PR changes are ready and waiting for maintainer re-review labels Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR changes are ready and waiting for maintainer re-review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant