Skip to content

chore: update Node.js to v22 LTS (22.23.1) - #743

Merged
edelauna merged 3 commits into
mainfrom
renovate/node-24.x
Jul 25, 2026
Merged

chore: update Node.js to v22 LTS (22.23.1)#743
edelauna merged 3 commits into
mainfrom
renovate/node-24.x

Conversation

@renovate

@renovate renovate Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Renovate proposed bumping Node from 20 → 24, but Node 24 triggers a deterministic libuv assertion abort on the Windows CI runner (`fs-event.c:72`, Windows Server 2025) causing `platform-unit-test (windows-latest)` to fail on every run. This is an upstream Node/libuv regression with no fix available yet.

This PR redirects the bump to Node 22 LTS (supported until 2027-04-30), which is stable on Windows.

Changes

  • `.nvmrc`, `.tool-versions`, `engines.node` (root + `src/`) → `22.23.1`
  • `.github/actions/setup-node-pnpm` CI default → `22.23.1`
  • `@types/node` → `22.20.1` across all workspace packages
  • `pnpm-lock.yaml` regenerated
  • `renovate.json`: cap `@types/node` to `22.x` so Renovate doesn't drift it back to 24

Why not Node 24?

`nodejs/node#56645` and related issues document a class of libuv assertion failures on Windows that affect Node 23/24. The specific crash here is:

```
Assertion failed: !_wcsnicmp(filename, dir, dirlen), file src\win\fs-event.c, line 72
```

It fires deterministically during `zoo-code:test:coverage` whenever the fs watcher is active. Linux CI is unaffected. A follow-up PR can re-attempt the Node 24 bump once an upstream patch lands.

@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@renovate
renovate Bot force-pushed the renovate/node-24.x branch 3 times, most recently from 9ef6744 to cd12bea Compare July 1, 2026 00:35
@github-actions github-actions Bot added has-conflicts PR has merge conflicts with the base branch and removed has-conflicts PR has merge conflicts with the base branch labels Jul 7, 2026
@github-actions github-actions Bot added has-conflicts PR has merge conflicts with the base branch and removed has-conflicts PR has merge conflicts with the base branch labels Jul 15, 2026
@github-actions github-actions Bot added the has-conflicts PR has merge conflicts with the base branch label Jul 18, 2026
@renovate
renovate Bot force-pushed the renovate/node-24.x branch from cd12bea to bd3aa07 Compare July 18, 2026 23:33
@github-actions github-actions Bot removed the has-conflicts PR has merge conflicts with the base branch label Jul 18, 2026
@renovate
renovate Bot force-pushed the renovate/node-24.x branch 3 times, most recently from 5fa9256 to 04f17bf Compare July 24, 2026 14:25
@edelauna
edelauna force-pushed the renovate/node-24.x branch from 04f17bf to fa4b73b Compare July 25, 2026 17:52
@edelauna edelauna changed the title chore(deps): update node.js to v24 chore: update Node.js to v22 LTS (22.23.1) Jul 25, 2026
@renovate

renovate Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@edelauna edelauna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping to v22 since v24 has issues with windows

@edelauna
edelauna added this pull request to the merge queue Jul 25, 2026
@edelauna
edelauna removed this pull request from the merge queue due to a manual request Jul 25, 2026
@edelauna
edelauna added this pull request to the merge queue Jul 25, 2026
Merged via the queue into main with commit e479b7e Jul 25, 2026
14 checks passed
@edelauna
edelauna deleted the renovate/node-24.x branch July 25, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant