forked from AliceO2Group/AliceO2
-
Notifications
You must be signed in to change notification settings - Fork 0
Adding class for V0 selection #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sartozza
wants to merge
314
commits into
a-mathis:femtoDream
Choose a base branch
from
sartozza:dev
base: femtoDream
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c12d3cd to
212669b
Compare
a-mathis
reviewed
Jul 1, 2021
Owner
a-mathis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this development! I have some minor comments, and one major - for now the task only allows one species at a time. For to my opinion, the task should be capable of running Lambda/Antilambda at the same time (+ even K0 eventually)
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamTrackSelection.h
Outdated
Show resolved
Hide resolved
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamTrackSelection.h
Outdated
Show resolved
Hide resolved
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamTrackSelection.h
Outdated
Show resolved
Hide resolved
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamV0Selection.h
Outdated
Show resolved
Hide resolved
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamV0Selection.h
Outdated
Show resolved
Hide resolved
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamV0Selection.h
Show resolved
Hide resolved
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamV0Selection.h
Outdated
Show resolved
Hide resolved
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamV0Selection.h
Outdated
Show resolved
Hide resolved
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamV0Selection.h
Outdated
Show resolved
Hide resolved
Analysis/Tasks/PWGCF/FemtoDream/include/FemtoDream/FemtoDreamV0Selection.h
Outdated
Show resolved
Hide resolved
- Add single particle QA task - Add 2D efficiency to efficiency QA task - Add possibility to select charge depending on PDG code - Add Y for MC particles
This is avoiding potential division-by-zero exceptions (seen on MacOS) by replacing the division with a signum operation.
…ceO2Group#6557) * Rework slicing algorithm for merged AODs solving O2-2424
MCparticles referred to the original eventIDs from the Geant transport, whereas they should refer to the MCcollision AOD table entry. Thanks to Nazar for discussions.
DPL output proxy automatically add message of type {DPL/EOS} to forward
end-of-stream on all output channels. If another DPL workflow connects
via raw proxy, it handles the channel info headers and can ignore the
actual message.
Also adding an option to test_ExternalFairMQDeviceWorkflow which allows
to drop the subscriber part of the test and instead connect the raw proxy.
…a data filter + newZSCalib helper function for TPC QC
* trd reading empty frames * safter sending of blank frames * ensure empty frame is indeed empty * flexible data description * move TRD eventrecord class to reconstruction dir * remove classdef for EventRecord, and local variables for emptry frames data
* Create pragmaonce.yml * Update pragmaonce.yml
Co-authored-by: Stefano Trogolo <strogolo@users.noreply.github.com>
* First step towards the simulation challenge For the time being is being a separate task The final goal is a single one Implemented - data collection directly in differential form - huge decrease in memory layout * Introduction of the data collecting engine structure The whole data collecting functionality is encapsulated into an structure which can be replicated as needed * Just a single task for the different cent/mult ranges The idea is to have a multitask scenario for running systematic tests in 'parallel' exclusively
…gment creation once
…also when process umask is set
…n association not available
* Implementation of the ITS Half Barrels * Fixing ITSMisaligner macro for new method names with Half Barrels * Do not set Layer as alignable volume * Fixed number of half barrels * Revert "Fixed number of half barrels" This reverts commit 4f52866. * Fixed number of half barrels * Correctly add half barrel number to hit generation and chip index number Co-authored-by: Mario Sitta <Mario.Sitta@cern.ch>
* Shorthand isPrimaryParticle * MC example with accessing particles and tracks * Remove MC.h from library
`ifnode(condition, then, else)` operation is added to expressions. These can be nested and all three arguments can be arbitrary valid expressions. `condition` needs to have boolean result, `then` and `else` should return similar types (ideally the same - both floats, or both boolean, etc.). A `conditionalExpressions.cxx` tutorial example is added (note that it uses bitwise operations in filter expression and thus will only work as is with arrow > 3).
* New task for the central event filter processor * Task configurables from table descriptions
Still not clear to me wether the condition can actually be triggered. It might explain phantom channels to the input proxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.