fix: fix flaky test testNonBlockingWithMultipleMessages

[cmtoan]

Description

fix flaky test testNonBlockingWithMultipleMessages

Fixes #557 🦕

[gemini-code-assist]

Summary of Changes

Hello @cmtoan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves a flaky test, testNonBlockingWithMultipleMessages, by implementing robust resource cleanup. The change ensures that any temporary tasks created by the test are consistently removed, thereby improving the reliability and stability of the test suite.

Highlights

• Flaky Test Fix: The testNonBlockingWithMultipleMessages test has been refactored to prevent flakiness by ensuring proper task cleanup.
• Resource Cleanup: A try-finally block was introduced to guarantee that the task created during the test (multi-event-test) is always deleted from the task store, regardless of test outcome.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a flaky test, testNonBlockingWithMultipleMessages, by ensuring proper cleanup of test resources. The change introduces a try-finally block to delete the task created during the test, which is a solid approach to prevent state leakage between test runs. I've added a suggestion to further improve test isolation by using a dynamically generated unique ID for the task, which would make the test more robust, especially in environments with parallel test execution.

[gemini-code-assist]

Using a try-finally block to ensure task cleanup is a great improvement for test stability. To make this test even more robust and prevent any potential conflicts from hardcoded IDs (e.g., if tests were to run in parallel in the future), consider using a unique ID for each test run. Appending a random UUID is a common pattern for this.

Suggested change

	String multiEventTaskId = "multi-event-test";
	String multiEventTaskId = "multi-event-test-" + java.util.UUID.randomUUID();