fix: Remove remaining jackson dependencies/imports #579
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the removal of all remaining Jackson library references from the codebase. The changes involve deleting Jackson dependencies from various Maven Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes Jackson dependencies and annotations. The dependency removals in the pom.xml files are correct. However, in ReplicatedEventQueueItem.java, the removal of @JsonIgnore annotations could lead to unintended fields in the JSON output, and one case might cause a serialization conflict. I've also suggested a minor naming improvement for consistency. Please see the detailed comments.
| */ | ||
| @JsonIgnore | ||
| @Override | ||
| public Event getEvent() { |
There was a problem hiding this comment.
The @JsonIgnore annotation was removed from this getEvent() method. This will likely cause it to be included during JSON serialization, which could conflict with the event field that is also serialized. To prevent potential duplicate data or serialization errors, please add the equivalent of @JsonIgnore from the new JSON library.
| public A2AError getErrorObject() { | ||
| return error; | ||
| } |
There was a problem hiding this comment.
For better consistency with Java bean conventions and the corresponding error field and setError() method, consider renaming this getter from getErrorObject() to getError().
| public A2AError getErrorObject() { | |
| return error; | |
| } | |
| public A2AError getError() { | |
| return error; | |
| } |
| */ | ||
| @JsonIgnore | ||
| @Override | ||
| public boolean isReplicated() { |
There was a problem hiding this comment.
With the removal of @JsonIgnore, this isReplicated() method will likely be serialized, adding a potentially unnecessary "replicated": true field to the JSON output. To maintain the previous behavior, please add the equivalent 'ignore' annotation from the new JSON library.
There was a problem hiding this comment.
There was a problem hiding this comment.
Please note that gson uses fields, not getter and setter for serialization
2 participants
No description provided.